4 Commits

Author	SHA1	Message	Date
claude	afe76c22ce	Fix bullet atlas, animation speed, sprite flip, fire rate, silent shots ... Bullet sprites were wrong because I read the pack's layout backwards. Each of its 8 PNGs is one ANIMATION FRAME, and a column within a file is a COLOUR variant -- so walking columns cycled the palette while the shape sat still, and the rows I picked were in a region of larger multi-cell sprites, which is the scattered debris that showed on screen. tools/build_local_assets.py now composes a proper atlas: 8 frames across, one row per SimConfig.KIND_*. Animations ran at whatever the machine's framerate was, because they counted _process calls. At 240fps that is four times too fast on its own, before the requested halving. Both actor and bullet animation are now driven by elapsed seconds, so they look the same on any machine. The knight shifted sideways instead of mirroring: a Rect2 with negative width does not flip, the draw call normalises it, so the sprite kept its orientation and jumped right by its own width. Mirrored through the canvas transform about the sprite's centre instead. Shots were silent when a bullet spawned inside an enemy. The sound rode on BULLET_SPAWN, which is deliberately suppressed for a bullet resolved and removed within the same tick -- so no event, no sound, and this got more likely the closer you stood. Firing is now its own event (PLAYER_FIRED): the shot happened whether or not a bullet survived to be replicated. Protocol 3 -> 4, because inserting mid-enum shifts the wire value of every event after it. Fire cooldown 7 -> 14 ticks (4.3 shots/sec). Licence question 2, confirmed verbatim: the paid tier DOES grant commercial use ("You may use these assets in personal, commercial or non-commercial projects"), but its next sentence still forbids redistribution "no matter how much you modify it". Paying moves these from local-only-and-non-commercial to local-only-and-commercial; it never makes them committable. Only replacing them with permissively licensed art does that. Question 3: CREDITS.md now credits every pack, including the two whose licences do not require it and the unused ones in considering_dont_use_yet/. 158 tests. check.sh, test.sh and smoke.sh pass.	2026-09-04 00:03:04 +02:00
claude	3586555aea	Remove non-redistributable art from the repo; record licence terms ... Researched the licence at each of the four itch.io sources. Two of the four forbid redistribution, and publishing a repository containing them is exactly that, so they are out of the tree. 0x72 DungeonTileset II CC0 1.0 commercial ok, no credit required Helton Yan Pixel Combat CC BY 4.0 commercial ok, CREDIT REQUIRED Fire Pixel Bullet 16x16 custom non-commercial, NO REDISTRIBUTION 750+ Effect and FX Pixel custom non-commercial, NO REDISTRIBUTION Both bdragon1727 packs state verbatim: "You cannot do: Resell / redistribute this asset." The FX pack's paid tier is no better for this purpose -- "You can NOT re-distribute the file, no matter how much you modify it" -- so paying does not unlock it and neither does editing the art. bullets.png and impact.png therefore move to assets/local/, gitignored. Art.bullets_texture() / impact_texture() load them at runtime and return null when absent; the bullet renderer falls back to the generated dot it used before, tinted per kind so bullet types stay distinguishable. Nothing there may be preload()ed -- preload resolves at compile time and would fail the build on every machine without the files, which is every clone. Verified both ways rather than assumed: with the files present the game uses them and no fallback triggers; with them moved aside, 156/156 tests pass and the game runs clean on the generated dots. Added CREDITS.md, because Helton Yan's CC BY 4.0 makes attribution a licence obligation rather than a courtesy. A file in the source tree does not discharge it once the game ships -- an in-game credits screen is now a tracked todo, and flagged as a licence requirement rather than polish. NOT addressed here, and it needs a decision: these files remain in git history at 9fa2e26. Removing them from the tip does not remove them from a clone. If this repo is ever made public, history has to be rewritten (git filter-repo) and force-pushed. Also, both bdragon packs are non-commercial in their free tier, which conflicts with the stated Steam goal -- either contribute for the commercial tier (still no redistribution) or replace with CC0 art, which would solve both problems and let the assets back into the repo.	2026-09-03 23:52:41 +02:00
claude	9fa2e260f2	Replace placeholder rendering with real sprites and audio ... Terrain, actors, boss and bullets are sprites now, and four sounds play off server events. 548KB total across seven files, out of 3.9GB of source packs. - src/view/art.gd holds every atlas rect and sound path in one table, copied from the 0x72 pack's own tile_list. Scattering coordinates through draw calls would make re-cutting the atlas a hunt, and a wrong rect invisible. - Bullets get one MultiMesh per kind rather than one overall: a MultiMeshInstance2D carries a single texture and each kind needs a different region of the sheet. Four draw calls, no custom shader passing UVs through per-instance data. - src/view/sfx.gd is a 16-voice round-robin pool. Bullet-hell fire rates mean sounds overlap constantly, and identical sounds landing within two frames are collapsed so a ring hitting eight bullets is a bang rather than clipping. Every sound is triggered by a server event, never a local guess, so what you hear matches what happened. Audio was converted, not copied: the pack ships 24-bit/96kHz masters averaging 2MB. Downsampled to 16-bit/44.1kHz mono, silence-trimmed, and the shoot sound hard-capped to 0.30s -- it came out at 2.03s, against a fire cooldown of 0.12s, which would have smeared held fire into noise. tests/unit/test_art.gd checks what cannot be eyeballed here: every atlas rect lands inside its texture, every animation frame of a strip fits (the last frame is what runs off the sheet, not the first), there is a sprite per bullet kind and per enemy visual, and no sound is long enough to stack badly. A wrong atlas coordinate does not error -- it silently draws the wrong pixels. Licence sources recorded in docs/ASSETS.md now that they are known. All four are free versions and four rows still say "confirm at source": free itch packs vary on credit and commercial use, and there is no credits screen yet. 155 tests (was 146). check.sh, test.sh and smoke.sh pass.	2026-09-03 23:43:13 +02:00
claude	20dd6bc502	Keep asset packs out of git and out of Godot's importer ... The packs total 3.9GB, almost all of it Helton Yan's SFX shipped as 24-bit / 96kHz studio masters -- ~2MB for a single gunshot. Two guards, because they solve different problems: - .gitignore excludes the contents. The directory and its guard files stay tracked, so a fresh clone has the .gdignore in place before anyone drops packs back in. - assetpacks/.gdignore stops Godot descending into the tree at all. This is the urgent half: tools/check.sh runs --import, which walks all of res://, so the next check would have imported several thousand PNGs and 2,100 of those WAVs, and every run after it. Verified by controlled test rather than assumed -- an unguarded PNG under res:// imports and gets a .import file beside it; with .gdignore neither happens. check.sh stays at 3.3s and .godot/imported at 1.2MB. The trade the .gdignore buys is that nothing in assetpacks/ can be referenced from a scene or script. That is the intended shape: raw source on one side, game-ready files copied into res://assets/ on the other, so adding a huge pack costs the repo and the import step nothing. docs/ASSETS.md records attribution, because gitignoring the packs also gitignores their licence files. Worth flagging: four of the six packs shipped with no licence text at all, and two of the undecided ones are demo versions, which are often more restricted than the paid packs. Only RF Catacombs has explicit terms (public domain, no resale). Those rows need a source URL before anything ships. Also removed __MACOSX and .DS_Store extraction artefacts, and left considering_dont_use_yet/ untouched as the user's own "not chosen" marker.	2026-09-03 23:24:54 +02:00