2 Commits

Author	SHA1	Message	Date
claude	132646f6c3	Rework the UI on Crusenho's pack; credit it in the game, not just the repo ... Crusenho's Complete UI Essential Pack is CC BY 4.0 -- redistributable and commercial-friendly, confirmed from the License.txt the pack itself ships -- so unlike the two bdragon packs a subset is committed: twelve PNGs, 48 KB, under assets/sprites/ui/. Only what is used, because each committed PNG costs a Godot .import sidecar and a directory nothing references is one nobody prunes. UiTheme builds a Theme in code from it -- button states, panels, line edits -- and every screen roots itself through UiTheme.themed_root(). The HUD's bars are the pack's frame with a tinted fill, drawn as three horizontal slices because Godot's nine-patch lives on nodes and the HUD is drawn rather than built from controls. Inventory slots use the pack's slot art at exactly twice the source size; a non-integer scale on a 1px border reads as a wobble along every edge. The credits screen is the other half of the request and it is a licence obligation, not a nicety: two packs are now CC BY, which asks for attribution "in any reasonable manner", and a markdown file in a source repo is not reasonable for someone who downloaded a build. Settings -> Credits shows every source with its terms and a link to the licence text. test_credits.gd asserts CREDITS.md and docs/ASSETS.md name every entry, so the three cannot drift. Two things found by actually looking at the screen, which is the point: - The FIRST version of this styled nothing. A Control inherits its theme from Control ANCESTORS only, and the chain breaks at the first plain Node or CanvasLayer -- which is every screen here. get_window().theme set the property, changed nothing, and read as correct. check.sh, 458 tests and a clean smoke run all passed with the entire interface unstyled. The theme test now instantiates every screen and asks what its buttons resolve. - The settings screen showed Fire bound to the right mouse button, because the test suite was writing the player's real user://settings.cfg -- rebinding calls save() and nothing had redirected the path. Settings.path is now redirectable, the fixture points it at a scratch file, and a test asserts the default is still the player's own. tools/screenshot.tscn is what found both. It boots the client windowed and saves the menus, the HUD, settings and credits. Manual, needs a display, and the only thing in the project that can tell you the interface rendered. check.sh clean, 460 tests, SMOKE PASS, all four diagnostics green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-07 11:12:13 +02:00
claude	872922e9e2	Fix boss jitter; add a settings screen for controls and volume ... The jitter had two causes, and the larger one is embarrassing: boss_state() handed back the newest snapshot raw while players and enemies both went through the interpolator. The boss therefore stepped at the 20Hz snapshot rate instead of the frame rate. Invisible for as long as every boss stood still, and the first one that moved looked broken. It is interpolated now -- but not across an instance change, where the previous snapshot describes a different fight in a different room and lerping to it would fling the new boss across the map for a frame. The smaller cause was server-side: a CHASE boss corrects by the SIGN of its distance error, so at the standoff the sign flipped every tick and the boss vibrated a couple of pixels at 60Hz. It has a dead band now. The settings screen covers rebindable controls and volume, reachable from both the main menu and the in-game menu. Bindings are stored as physical keycodes -- following key position, the choice setup_input_map.gd already made -- and labelled back through the active layout so an AZERTY player reads the letter on the key their fingers are on. A rebind replaces every event on the action rather than the first, because an action that kept its alternates would still answer to the key you just moved away from. A key already in use is refused and the clash is named. Reset restores what the PROJECT shipped, captured once before anything overrides it -- captured later it would restore the last session's choice, which is the thing being undone. Effects play on an SFX bus created at runtime, so both sliders are real mixer settings rather than a number multiplied into every play() call. Worth recording: the test suite AND the smoke test both passed while a client logged twelve engine errors on every startup. ConfigFile.get_value(s, k, null) does not mean "no default" -- it means the key is absent and no default was given, and the engine logs an error per action. Nothing caught it because the smoke refutations matched SCRIPT ERROR and friends, and a plain ERROR: is none of those. It surfaced from running the client and reading the output. smoke.sh now asserts no plain engine errors either, excluding by name the one line Godot prints on every clean exit, and reintroducing the bug makes it fail. One mutation caught nothing and should not have: the early return in linear_to_db_clamped was dead code, since the clamp beneath it already prevents negative infinity. Removed rather than left looking tested. check.sh clean, 439 tests, SMOKE PASS (23 assertions), all four diagnostics green, and a real client boots with zero engine errors. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-07 10:56:44 +02:00