4 Commits

Author	SHA1	Message	Date
claude	b351bc2d55	Stage 4: upgrades, and a quartermaster to spend them at ... Every level banks one choice. Choices queue, and are spent at an NPC in the hub: walk to it, press E, take one of three weighted options. Seven upgrades, all data — split shot, glass cannon, spread, sniper, doubleshot, poison, eraser — and SimWorld gained no per-upgrade branch to run any of them. The four ambiguities in the brief were settled with the user first, since each changes what gets written: damage base x (1 + sum additive) x product multiplicative. The flat +5% every upgrade carries, spread's -10%, doubleshot's -50% and glass cannon's +100% pool; sniper multiplies on top, so two snipers is 4x and not +200%. glass half the LEVELLED maximum, multiplying if taken twice, so the price does not fade to a rounding error by level 15. poison independent stacks, not a refresh. split +/-45 degrees from the original heading. Independent poison stacks sound expensive and are not: every dose lasts the same number of ticks, so doses expire in the order they were added, the pending expiries are a plain FIFO, and PoisonTrack only ever looks at its front. O(1) per actor per tick however many are live. Stats are derived from the upgrade list and never stored, the way level is derived from experience -- a saved stat cannot disagree with the upgrades that produced it. Upgrade riders (split charges, poison, erase chance) travel on the bullet instead, because a shot in flight has to keep what it was fired with rather than gaining Poison because the shooter just took it. Two invariants this collided with, both now pinned: - bullet speed gained a ceiling. Wall collision samples once per tick, so anything over a tile per tick tunnels; two snipers asked for 2480 u/s against a 1920 threshold, and a tunnelling bullet looks like a bullet. - BULLET_INTEREST_RADIUS rose to 2900, because an upgraded player shot is now the longest-travelling bullet in the game. test_interest measured the worst case from static content, which upgrades quietly invalidated. Choosing is intent checked three ways: a choice must be owed, the index must name one of the three options the SERVER put on the table, and the player must be standing at the NPC. The offer is rolled once and persisted, so closing the screen is not a reroll and neither is a crash. tools/diag_upgrades.tscn covers level -> banked choice -> refused in a dungeon and refused across the room -> taken at the NPC -> new stats -> on disk. Bots never walk to the quartermaster, so the smoke test cannot. Known gap recorded in the roadmap: at PLAYER_BULLET_DAMAGE = 6, the +5% the first upgrade carries rounds back to 6 and visibly does nothing. It comes out right in aggregate, but the fix is a balance edit across content.gd and so is the user's call. check.sh clean, 357 tests, SMOKE PASS (18 assertions), all four diagnostics green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-06 15:34:58 +02:00
claude	050b8251a7	Stage 3: inventory, ground loot, and two loot visibilities ... Four always-on-screen slots, items as data, and loot tables on enemies and bosses. Health potions drop rarely from trash and always from the Warden; the Warden also drops a Warden's Ration, one per living player, which does nothing at all. The ration is not filler. Player-instanced loot is a separate code path from shared loot -- a distinct entity per owner, filtered per peer in the snapshot encoder -- and the cheapest way to keep that path honest is to have something in the game that exercises it on every boss kill. Item actions ride the input frame rather than becoming new client messages. InputFrame gained BTN_USE, BTN_DROP and a slot byte, which buys the packet-loss redundancy, the replay guard on last_input_tick, ordering against movement on the same tick, and a rate limit of one action per tick -- all of which a separate RPC would have needed bolted back on. The cost is that anything in the frame which must not repeat has to be edge-triggered, since frames are resent and a starved server coasts on the last one it holds. Instanced loot is enforced in NetCodec.encode_snapshot, beside the actor interest radius: a peer is never told another player's copy exists. Hiding it client-side would have been the same mistake as relying on fog to hide enemies. Inventories live on the character and are written to the store on every transaction, so a crash between "picked it up" and "wrote it down" cannot lose or duplicate an item. Anything dropped becomes world-shared whatever it was before, and a potion used at full health is refused rather than spent. tools/diag_loot.tscn covers drop -> snapshot -> pick up -> persist -> use -> drop plus both visibilities on the wire, for the same reason diag_progression exists: bots are poor shots and almost never produce a drop. It asserts each input frame was actually consumed, after an early version silently dropped its first press and every later check passed for the wrong reason. check.sh clean, 266 tests, SMOKE PASS, all three diagnostics green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-04 21:16:15 +02:00
claude	d8197885ca	Hide dead characters, suggest names, make the XP bar live ... The roster sent to clients now contains living characters only. Retirement stays server-side bookkeeping for archival; from the player's side a dead character is simply gone, and listing it offers a choice that cannot be taken. The XP bar only moved on a level-up or a character swap because it read the character roster, which is re-sent only when the SET of characters changes. Experience now rides the snapshot -- four bytes on a message already going out at 20Hz -- and the server mirrors each grant into the world immediately rather than only when a level is crossed. The create field starts with a suggested name instead of blank, and offers another after each creation. Two bugs found while testing, both mine: The first was a bad patch of my own: a change meant for the snapshot decoder also matched inside decode_characters, which then read a four-byte field its encoder never wrote and ran off the end of every packet. This is precisely the "encodes but decodes wrong" failure the codec tests exist to catch, and it was caught within a minute of the test being written. Chasing that exposed a real robustness gap: StreamPeerBuffer.get_utf8_string() pushes an engine error and returns garbage when the buffer is short, so a truncated or hostile character/roster packet produced error spam instead of degrading. Both decoders now bounds-check every field, with tests that slice each packet at many lengths and assert it degrades rather than inventing entries -- the same guarantee the input decoder already had. 206 tests. check.sh, test.sh, smoke.sh and both diagnostics pass.	2026-09-04 01:12:53 +02:00
claude	4765bbce28	Stage 2: accounts, characters, permadeath, levels and experience ... Identity is shaped like Steamworks so swapping to it is one subclass and no schema change: the client presents an opaque ticket, the server validates it into a stable 64-bit account id, and nothing downstream sees anything else. LocalAuthProvider takes any ticket at face value -- insecure on purpose, and labelled as such everywhere, because the point is the shape rather than the security. Do not ship it. Characters persist as JSON keyed by account. Account ids are written as decimal strings because they are 64-bit and JSON numbers are doubles, which would silently round them. A corrupt store aborts the server rather than starting empty: starting empty looks like it worked and then saves over every character on the first level-up. Levels 1-15, +10 max health each, level DERIVED from lifetime experience rather than stored beside it, so a hand-edited save cannot produce a level 12 character with a level 3's experience. Experience is shared undivided across everyone alive in the instance -- splitting it would make bringing a friend cost you progress. A level-up heals by what it added, so gaining one mid-fight is relief rather than a bar that moved further from full. Death is permanent and unbinds the character entirely: no "return to the hub as the character who just died", because the run is over. The record is retired, never deleted. The five-character cap counts LIVING characters only -- counting the dead would lock a player out of their own account after five deaths. Verified by tools/diag_progression.tscn, which drives the real server through kill -> xp -> level -> health and death -> retire -> roster. The bot smoke test cannot cover that: bots are poor shots and rarely kill anything. Writing it caught two real ordering bugs -- the death event was dispatched before the payload that tells the player they died, and the dead character stayed bound to the peer. Also added --account and --store so several clients and test runs can coexist on one machine. The smoke test now uses a scratch store; without it a rerun resumed the previous run's characters and "a character was created" quietly stopped being true. 193 tests. check.sh, test.sh, smoke.sh, diag_progression and diag_prediction all pass.	2026-09-04 00:44:34 +02:00