3 Commits

Author	SHA1	Message	Date
claude	132646f6c3	Rework the UI on Crusenho's pack; credit it in the game, not just the repo ... Crusenho's Complete UI Essential Pack is CC BY 4.0 -- redistributable and commercial-friendly, confirmed from the License.txt the pack itself ships -- so unlike the two bdragon packs a subset is committed: twelve PNGs, 48 KB, under assets/sprites/ui/. Only what is used, because each committed PNG costs a Godot .import sidecar and a directory nothing references is one nobody prunes. UiTheme builds a Theme in code from it -- button states, panels, line edits -- and every screen roots itself through UiTheme.themed_root(). The HUD's bars are the pack's frame with a tinted fill, drawn as three horizontal slices because Godot's nine-patch lives on nodes and the HUD is drawn rather than built from controls. Inventory slots use the pack's slot art at exactly twice the source size; a non-integer scale on a 1px border reads as a wobble along every edge. The credits screen is the other half of the request and it is a licence obligation, not a nicety: two packs are now CC BY, which asks for attribution "in any reasonable manner", and a markdown file in a source repo is not reasonable for someone who downloaded a build. Settings -> Credits shows every source with its terms and a link to the licence text. test_credits.gd asserts CREDITS.md and docs/ASSETS.md name every entry, so the three cannot drift. Two things found by actually looking at the screen, which is the point: - The FIRST version of this styled nothing. A Control inherits its theme from Control ANCESTORS only, and the chain breaks at the first plain Node or CanvasLayer -- which is every screen here. get_window().theme set the property, changed nothing, and read as correct. check.sh, 458 tests and a clean smoke run all passed with the entire interface unstyled. The theme test now instantiates every screen and asks what its buttons resolve. - The settings screen showed Fire bound to the right mouse button, because the test suite was writing the player's real user://settings.cfg -- rebinding calls save() and nothing had redirected the path. Settings.path is now redirectable, the fixture points it at a scratch file, and a test asserts the default is still the player's own. tools/screenshot.tscn is what found both. It boots the client windowed and saves the menus, the HUD, settings and credits. Manual, needs a display, and the only thing in the project that can tell you the interface rendered. check.sh clean, 460 tests, SMOKE PASS, all four diagnostics green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-07 11:12:13 +02:00
claude	afe76c22ce	Fix bullet atlas, animation speed, sprite flip, fire rate, silent shots ... Bullet sprites were wrong because I read the pack's layout backwards. Each of its 8 PNGs is one ANIMATION FRAME, and a column within a file is a COLOUR variant -- so walking columns cycled the palette while the shape sat still, and the rows I picked were in a region of larger multi-cell sprites, which is the scattered debris that showed on screen. tools/build_local_assets.py now composes a proper atlas: 8 frames across, one row per SimConfig.KIND_*. Animations ran at whatever the machine's framerate was, because they counted _process calls. At 240fps that is four times too fast on its own, before the requested halving. Both actor and bullet animation are now driven by elapsed seconds, so they look the same on any machine. The knight shifted sideways instead of mirroring: a Rect2 with negative width does not flip, the draw call normalises it, so the sprite kept its orientation and jumped right by its own width. Mirrored through the canvas transform about the sprite's centre instead. Shots were silent when a bullet spawned inside an enemy. The sound rode on BULLET_SPAWN, which is deliberately suppressed for a bullet resolved and removed within the same tick -- so no event, no sound, and this got more likely the closer you stood. Firing is now its own event (PLAYER_FIRED): the shot happened whether or not a bullet survived to be replicated. Protocol 3 -> 4, because inserting mid-enum shifts the wire value of every event after it. Fire cooldown 7 -> 14 ticks (4.3 shots/sec). Licence question 2, confirmed verbatim: the paid tier DOES grant commercial use ("You may use these assets in personal, commercial or non-commercial projects"), but its next sentence still forbids redistribution "no matter how much you modify it". Paying moves these from local-only-and-non-commercial to local-only-and-commercial; it never makes them committable. Only replacing them with permissively licensed art does that. Question 3: CREDITS.md now credits every pack, including the two whose licences do not require it and the unused ones in considering_dont_use_yet/. 158 tests. check.sh, test.sh and smoke.sh pass.	2026-09-04 00:03:04 +02:00
claude	3586555aea	Remove non-redistributable art from the repo; record licence terms ... Researched the licence at each of the four itch.io sources. Two of the four forbid redistribution, and publishing a repository containing them is exactly that, so they are out of the tree. 0x72 DungeonTileset II CC0 1.0 commercial ok, no credit required Helton Yan Pixel Combat CC BY 4.0 commercial ok, CREDIT REQUIRED Fire Pixel Bullet 16x16 custom non-commercial, NO REDISTRIBUTION 750+ Effect and FX Pixel custom non-commercial, NO REDISTRIBUTION Both bdragon1727 packs state verbatim: "You cannot do: Resell / redistribute this asset." The FX pack's paid tier is no better for this purpose -- "You can NOT re-distribute the file, no matter how much you modify it" -- so paying does not unlock it and neither does editing the art. bullets.png and impact.png therefore move to assets/local/, gitignored. Art.bullets_texture() / impact_texture() load them at runtime and return null when absent; the bullet renderer falls back to the generated dot it used before, tinted per kind so bullet types stay distinguishable. Nothing there may be preload()ed -- preload resolves at compile time and would fail the build on every machine without the files, which is every clone. Verified both ways rather than assumed: with the files present the game uses them and no fallback triggers; with them moved aside, 156/156 tests pass and the game runs clean on the generated dots. Added CREDITS.md, because Helton Yan's CC BY 4.0 makes attribution a licence obligation rather than a courtesy. A file in the source tree does not discharge it once the game ships -- an in-game credits screen is now a tracked todo, and flagged as a licence requirement rather than polish. NOT addressed here, and it needs a decision: these files remain in git history at 9fa2e26. Removing them from the tip does not remove them from a clone. If this repo is ever made public, history has to be rewritten (git filter-repo) and force-pushed. Also, both bdragon packs are non-commercial in their free tier, which conflicts with the stated Steam goal -- either contribute for the commercial tier (still no redistribution) or replace with CC0 art, which would solve both problems and let the assets back into the repo.	2026-09-03 23:52:41 +02:00